dav3r
a0f24937d6
Fix a typo
3 years ago
Nick M
81cdb4da94
Merge pull request #84 from cisagov/improvement/replace_beautysh_with_shfmt
...
Replace beautysh hook with cisagov/pre-commit-shfmt
3 years ago
Nicholas McDonnell
3e83a800f0
Merge branch 'develop' into improvement/replace_beautysh_with_shfmt
3 years ago
Nick M
0e4fc41e4f
Merge pull request #82 from cisagov/improvement/install-tf-and-packer-for-linting
...
Install terraform and packer for the linting job
3 years ago
Nick M
3e3b918cbe
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
3 years ago
Nick M
382c39c4e9
Merge pull request #79 from cisagov/improvement/update_mdl_configuration
...
Update markdownlint Configuration
3 years ago
Shane Frasier
f6ad0e95d3
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
3 years ago
Nick M
e607360128
Merge branch 'develop' into improvement/update_mdl_configuration
3 years ago
Nick M
41a52860b8
Merge pull request #80 from cisagov/improvement/add_pre-commit_hook
...
Add the validate_manifest Hook to pre-commit Configuration
3 years ago
Nick M
c17800a7fd
Merge branch 'develop' into improvement/add_pre-commit_hook
3 years ago
Nick M
d7dcfee3b5
Merge pull request #83 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
Nicholas McDonnell
1708b5c45a
Update pre-commit hooks
...
This is performed by running `pre-commit autoupdate`, but with the
`ansible-lint` hook held back manually.
3 years ago
Nicholas McDonnell
2b48e75b23
Apply changes from the shfmt pre-commit hook
3 years ago
Nicholas McDonnell
406b6880bd
Replace the beautysh hook with pre-commit-shfmt
...
We have had a difficult time with how beautysh parses some shellscripts. I went
in pursuit of an alternative and I believe shfmt to be a good alternative.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
Nicholas McDonnell
e2a729d0b1
Install the shfmt tool for GHA
...
The `shfmt` tool does not ship on the GitHub Actions runners so we must install
it manually.
3 years ago
Shane Frasier
8ee2116f42
Prefer the newer "go install" syntax
...
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command ) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Shane Frasier
337d1efb8f
Capitalize Go for consistency
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
bb6e566e3a
Move go installation so that it takes place before the cache task
...
Some variables defined in the go installation are used in the cache
task, so the go installation must happen first.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
181d1b2faf
Install a specific version of terraform-docs
...
Note that this change is dependent on the merging of
cisagov/setup-env-github-action#31 .
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
b629f7f623
Modify the Packer installation to model that of Terraform
...
The Terraform installation does not destroy the existing system
Terraform installation, and neither should the Packer installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
70414cff28
Remove unnecessary line in tasks
...
There is no reason to create /usr/bin/terraform. This is a vestige of
an earlier age.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Shane Frasier
c481043981
Break out the curl cache creation into its own step
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
106af21c04
Install terraform and packer for the linting job
...
We should be doing this because the Packer and Terraform pre-commit
hooks leverage the corresponding executables; therefore, it makes
sense to go ahead and install the particular versions of those
executables that we support. Also add support for optionally
debugging via tmate.
See also cisagov/skeleton-generic#74 .
3 years ago
Nicholas McDonnell
d4781ee177
Add the validate_manifest hook from pre-commit
...
This hook will validate any pre-commit hook manifest files in the repository.
3 years ago
Nicholas McDonnell
f2a423095e
Add comments to markdownlint configuration
...
Now that this is a YAML file we can add comments explaining the rule
modifications we use. This will make it easier to edit or expand in the future.
3 years ago
Nicholas McDonnell
ce173f401d
Switch to a YAML markdownlint configuration file
...
This converts the existing `.mdl_config.json` file to an equivalent
`.mdl_config.yaml` file. The reference in the markdownlint pre-commit hook
configuration is updated to match.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
Nicholas McDonnell
afc6bd6f6d
Add rule for image headers
...
Add <h1> and <img> tags to the allowed list for MD033 (HTML elements) to
support using an image as the first thing in a markdown file (header image).
3 years ago
Nicholas McDonnell
1e8f822391
Add style enforcement rules
...
Add rules to enforce ATX-closed headers, dashes for unordered list elements,
and `1.` for ordered list elements.
3 years ago
Nick M
b0e7f014e3
Merge pull request #70 from cisagov/improvement/gitignore_me
...
Improve gitignore file comments and organization.
3 years ago
Nick M
e140c33929
Merge branch 'develop' into improvement/gitignore_me
3 years ago
Nick M
02aefa1644
Merge pull request #75 from cisagov/documentation/update_pyenv_instructions
...
Update Instructions for Configuring pyenv
3 years ago
Nick M
b486037f8b
Merge branch 'develop' into documentation/update_pyenv_instructions
3 years ago
Nick M
01b06c4e20
Merge pull request #72 from cisagov/maintenance/remove_user_from_codeowners
...
Remove User from CODEOWNERS
3 years ago
Nick M
39a67fce0f
Merge branch 'develop' into maintenance/remove_user_from_codeowners
3 years ago
Nick M
bd12db16be
Merge pull request #71 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
Nicholas McDonnell
23b324befc
Update configuration instructions for pyenv
...
With the release of pyenv v2.0.0 there is a breaking change around startup
logic that necessitates an update for our pyenv setup instructions. Also
add a statement about how to get configuration instructions from pyenv
itself.
3 years ago
Nicholas McDonnell
03494999d6
Update pre-commit hooks
...
Hooks updated with the `pre-commit autoupdate` command.
Note:
The `ansible-lint` hook is intentionally being held back on 4.3.7 because of
ongoing issues with the 5.x version and how we use Ansible (standalone Galaxy
roles).
3 years ago
Nicholas McDonnell
2c4d7a2504
Remove user from CODEOWNERS
...
Due to her departure this removes hillaryj from the default CODEOWNERS we use
in our projects.
3 years ago
Felddy
ba49077ab4
Improve gitignore file comments and organization.
...
* Add a comment describing what the files does.
* Add sections to organize patterns.
3 years ago
Nick M
09744fad25
Merge pull request #67 from cisagov/improvement/add_beautysh_pre-commit_hook
...
Add the beautysh pre-commit hook
3 years ago
Nick M
c025046068
Merge branch 'develop' into improvement/add_beautysh_pre-commit_hook
3 years ago
Nick M
33138501e2
Merge pull request #69 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
Nicholas McDonnell
c97a883ada
Revert ansible-lint version update
...
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in https://github.com/cisagov/skeleton-ansible-role/issues/69 .
3 years ago
Nicholas McDonnell
6bd93ff6fb
Update pre-commit hooks with `pre-commit autoupdate`
3 years ago
Nicholas McDonnell
ecdfc527d4
Add the beautysh pre-commit hook
...
This hook performs auto-formatting (beautifying) of Bash scripts.
3 years ago
Nick M
09f4f549a8
Merge pull request #65 from cisagov/improvement/enable_yamllint_strict
...
Use the --strict Flag for the yamllint pre-commit Hook
3 years ago
Nick M
9d909dacd8
Merge branch 'develop' into improvement/enable_yamllint_strict
3 years ago
Nick M
23838191be
Merge pull request #64 from cisagov/improvement/add_pre-commit-packer
...
Add the pre-commit-packer Repo and Hooks to the pre-commit Configuration
3 years ago
Nick M
be43230b7b
Merge branch 'develop' into improvement/add_pre-commit-packer
3 years ago
Nick M
01e3f843c9
Merge pull request #63 from cisagov/pre-commit_hook_maintenance
...
pre-commit Hook Maintenance and Update
3 years ago