Nicholas McDonnell
2c4d7a2504
Remove user from CODEOWNERS
...
Due to her departure this removes hillaryj from the default CODEOWNERS we use
in our projects.
2021-04-15 11:53:57 -04:00
Nick M
09744fad25
Merge pull request #67 from cisagov/improvement/add_beautysh_pre-commit_hook
...
Add the beautysh pre-commit hook
2021-02-16 17:08:50 -05:00
Nick M
c025046068
Merge branch 'develop' into improvement/add_beautysh_pre-commit_hook
2021-02-16 17:07:12 -05:00
Nick M
33138501e2
Merge pull request #69 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
2021-02-16 17:06:58 -05:00
Nicholas McDonnell
c97a883ada
Revert ansible-lint version update
...
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in https://github.com/cisagov/skeleton-ansible-role/issues/69 .
2021-02-16 13:18:45 -05:00
Nicholas McDonnell
6bd93ff6fb
Update pre-commit hooks with pre-commit autoupdate
2021-02-11 13:04:14 -05:00
Nicholas McDonnell
ecdfc527d4
Add the beautysh pre-commit hook
...
This hook performs auto-formatting (beautifying) of Bash scripts.
2021-01-15 10:36:02 -05:00
Nick M
09f4f549a8
Merge pull request #65 from cisagov/improvement/enable_yamllint_strict
...
Use the --strict Flag for the yamllint pre-commit Hook
2021-01-07 11:13:43 -05:00
Nick M
9d909dacd8
Merge branch 'develop' into improvement/enable_yamllint_strict
2021-01-07 11:10:05 -05:00
Nick M
23838191be
Merge pull request #64 from cisagov/improvement/add_pre-commit-packer
...
Add the pre-commit-packer Repo and Hooks to the pre-commit Configuration
2021-01-07 11:09:48 -05:00
Nick M
be43230b7b
Merge branch 'develop' into improvement/add_pre-commit-packer
2021-01-07 11:06:07 -05:00
Nick M
01e3f843c9
Merge pull request #63 from cisagov/pre-commit_hook_maintenance
...
pre-commit Hook Maintenance and Update
2021-01-07 11:05:53 -05:00
Nicholas McDonnell
2fb4e15cf6
Add the --strict flag to the yamllint pre-commot hook
...
The --strict flag will cause the yamllint hook to exit with a non-zero exit
code when warnings are found instead of only when errors are found.
2021-01-07 04:07:38 -05:00
Nicholas McDonnell
8f7435a6fa
Add the pre-commit-packer repo and hooks
2020-12-31 15:09:53 -05:00
Nicholas McDonnell
362b054459
Run pre-commit autoupdate
2020-12-31 15:08:07 -05:00
Nicholas McDonnell
46ec3e7002
Update ansible-lint hook URL
2020-12-31 15:06:18 -05:00
Nicholas McDonnell
d836e91d32
Update repo URL for the isort hook
...
I missed that this repository was transfered from the creator, Timothy Crosley,
to the PyCQA organization.
2020-12-17 13:50:34 -05:00
Nicholas McDonnell
06159cbb65
Run pre-commit autoupdate
2020-12-16 18:30:17 -05:00
Nicholas McDonnell
a7f86ddad0
Enable two additional hooks from default pre-commit-hooks
...
Enabled 'check-case-conflict' because of our mixed Linux and macOS development.
Although APFS supports case-sensitive containers, it is not the default as far
as I am aware. Linux filesystems are typically case-sensitive however.
With the merge of https://github.com/cisagov/development-guide/pull/42 we now
have a TOML file in a repository, so it does not hurt to add this hook in case
more are added in the future.
2020-12-16 18:21:03 -05:00
Nicholas McDonnell
5115baee52
Remove trailing '.git's from repository URLs
...
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we
should be consistent in how we format things.
2020-12-16 18:15:03 -05:00
Nicholas McDonnell
2d6bf50eab
Update black hook repo url
...
At some point the python GitHub organization renamed to psf (Python Software
Foundation). Although it redirects with no issue, I think it should be updated
to reflect the current repository URL.
2020-12-16 18:13:04 -05:00
Nicholas McDonnell
b769825c41
Update prettier hook details
...
Per https://github.com/prettier/prettier/pull/8937 the pre-commit hook has
been moved to https://github.com/pre-commit/mirrors-prettier . I have also
updated to the latest version in that repository.
2020-12-16 18:03:13 -05:00
Nick M
df674df714
Merge pull request #62 from cisagov/improvement/clean_up_actions/cache
...
Improve actions/cache Configuration
2020-12-03 10:18:06 -05:00
Nicholas McDonnell
f4131e57d8
Clean up our actions/cache step
...
Removed name because it was not more informative than the default. Swapped out
a hardcoded job reference for the github.job context value. Switch the base
cache key to a step environment value so we can set it once and reuse. Removed
additional restore-key value that might have undesirable results.
2020-11-20 12:22:39 -05:00
Shane Frasier
3b312c43d4
Merge pull request #59 from cisagov/improvement/get-python-version-more-simply
...
Use the python version output by actions/setup-python
2020-11-18 11:50:11 -05:00
Shane Frasier
b638143238
Merge branch 'develop' into improvement/get-python-version-more-simply
2020-11-18 11:48:22 -05:00
Shane Frasier
2a2067f1c7
Merge pull request #57 from cisagov/improvement/insist-that-devs-own-gihub-dir
...
Ensure that the cisagov devs are the owners of the .github directory
2020-11-18 11:48:13 -05:00
Shane Frasier
1310cfd468
Merge branch 'develop' into improvement/insist-that-devs-own-gihub-dir
2020-11-18 11:46:43 -05:00
Nick M
763d2474c7
Merge pull request #60 from cisagov/organize_pre-commit_requirements
...
Organize and Sort pre-commit Hooks
2020-11-18 11:42:16 -05:00
Nicholas McDonnell
64c3fb61ab
Organize pre-commit hooks
...
Group related pre-commit hooks together. Make sure that hooks are
alphabetically sorted within those groups.
2020-11-15 23:02:59 -05:00
Jeremy Frasier
02c5a6f8bf
Use the python version output by actions/setup-python
...
There is no need to run python code to determine the python version.
Resolves #58 .
See here for details:
https://github.com/actions/setup-python/blob/main/action.yml#L14-L16
2020-11-10 22:22:15 -05:00
Jeremy Frasier
5b199bc869
Remove offending slash
...
Thanks to @dav3r and @mcdonnnj for the suggestion.
2020-11-03 14:51:18 -05:00
Jeremy Frasier
a842abbfef
Insist that the cisagov devs are the owners of the .github directory
...
This additional clause must remain at the _end_ of the CODEOWNERS file
so that it cannot be overridden by a later clause.
We want to make it so that all the .github files including CODEOWNERS
are protected so only code owners (the dev team) can approve
modifications to them.
This will prevent configuration changes from breaking Actions and
other management-type functions that the files in this directory
control. By setting the .github files/folder to require code owner
approval for changes, workflow and management changes will require dev
team review and checking.
Resolves #56 .
2020-11-03 12:46:39 -05:00
Nick M
e44762c82f
Merge pull request #55 from cisagov/migrate_prettier_hook
...
Change repo for the prettier pre-commit hook
2020-10-22 13:54:40 -04:00
Nicholas McDonnell
919460cb21
Change repo for the prettier pre-commit hook
...
Per https://github.com/prettier/prettier/issues/9459 and specifically
https://github.com/prettier/prettier/issues/9459#issuecomment-713223710
the prettier hook for pre-commit is being broken out into its own repo.
2020-10-22 13:42:10 -04:00
Nick M
4d88e06e99
Merge pull request #54 from cisagov/pre-commit_updates
...
Update pre-commit Hooks
2020-10-22 10:48:16 -04:00
Nick M
1928db67bc
Merge branch 'develop' into pre-commit_updates
2020-10-22 10:44:39 -04:00
Nick M
a9ef644774
Merge pull request #53 from cisagov/add-how-to-skeleton
...
Add link to how to set up a new repo with skeletons
2020-10-22 10:44:26 -04:00
Nicholas McDonnell
59eef4cc77
Run pre-commit autoupdate
2020-10-19 11:53:09 -04:00
Nicholas McDonnell
de409db3f7
Use local filename in README link
2020-10-19 11:52:09 -04:00
Nicholas McDonnell
b5ef97dd4b
Remove seed-isort-config pre-commit hook
...
As of isort >=5, which we use, the seed-isort-config hook has been deprecated,
and the repository archived. I have removed the hook and the configuration
options it updated as a result.
2020-10-19 11:49:41 -04:00
Hillary
57d927d7d1
Add line breaks for linting
...
Pre-commit is now installed properly.
2020-10-09 10:10:12 -04:00
Hillary
e14ecde029
Add link to how to set up a new repo with skeletons
2020-10-09 10:07:04 -04:00
Mark Feldhousen
0923631e27
Merge pull request #52 from cisagov/improvement/workflows
...
Workflow improvements: 🦁 set-env, and 🐯 python-3.9, and 🐻 dependabot, oh my!
2020-10-07 13:53:37 -04:00
Felddy
7389a1b0cf
Enable weekly dependabot scans of github-actions and pip
2020-10-07 12:43:54 -04:00
Felddy
c9c00f1d03
Replace deprecated set-env workflow syntax
...
See:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-07 12:42:59 -04:00
Felddy
6a4164dfba
Bump build workflow python-version to 3.9
2020-10-07 12:41:47 -04:00
Nick M
15411447a6
Merge pull request #51 from cisagov/pre-commit_updates
...
Autoupdate pre-commit and Additional Maintenance
2020-09-04 10:06:54 -04:00
Nicholas McDonnell
d8f14e845b
Sort .gitignore while I'm here
2020-09-03 16:32:30 -04:00
Nicholas McDonnell
ae4aa123c8
Update lint job to resolve #49
2020-09-03 16:31:23 -04:00
