Nicholas McDonnell
23f9cfd015
Update pre-commit hooks
...
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with switching to v5.
2021-08-18 08:56:48 -04:00
Nicholas McDonnell
9848ff6944
Add a markdownlint rule for code blocks
...
This sets a specific rule for MD046 (code block style) instead of the default
value of "consistent".
2021-08-10 11:38:39 -04:00
Nicholas McDonnell
7f324b9807
Add a markdownlint rule for horizontal rules
...
This sets a specific rule for MD035 (Horizontal rule style) instead of the
default value of "consistent".
2021-08-10 11:36:33 -04:00
Nicholas McDonnell
f7140d8116
Use the hashicorp/setup-terraform Action
...
Instead of manually installing a Terraform binary we can leverage the Action
provided by Hashicorp to do the same thing.
2021-08-09 23:42:42 -04:00
dav3r
a0f24937d6
Fix a typo
2021-08-04 09:30:18 -04:00
Nick M
81cdb4da94
Merge pull request #84 from cisagov/improvement/replace_beautysh_with_shfmt
...
Replace beautysh hook with cisagov/pre-commit-shfmt
2021-07-19 13:21:16 -04:00
Nicholas McDonnell
3e83a800f0
Merge branch 'develop' into improvement/replace_beautysh_with_shfmt
2021-07-19 13:15:28 -04:00
Nick M
0e4fc41e4f
Merge pull request #82 from cisagov/improvement/install-tf-and-packer-for-linting
...
Install terraform and packer for the linting job
2021-07-19 13:11:38 -04:00
Nick M
3e3b918cbe
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
2021-07-19 13:06:12 -04:00
Nick M
382c39c4e9
Merge pull request #79 from cisagov/improvement/update_mdl_configuration
...
Update markdownlint Configuration
2021-07-19 13:05:43 -04:00
Shane Frasier
f6ad0e95d3
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
2021-07-19 13:03:55 -04:00
Nick M
e607360128
Merge branch 'develop' into improvement/update_mdl_configuration
2021-07-19 13:03:37 -04:00
Nick M
41a52860b8
Merge pull request #80 from cisagov/improvement/add_pre-commit_hook
...
Add the validate_manifest Hook to pre-commit Configuration
2021-07-19 13:02:49 -04:00
Nick M
c17800a7fd
Merge branch 'develop' into improvement/add_pre-commit_hook
2021-07-19 12:56:21 -04:00
Nick M
d7dcfee3b5
Merge pull request #83 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
2021-07-19 12:56:09 -04:00
Nicholas McDonnell
1708b5c45a
Update pre-commit hooks
...
This is performed by running `pre-commit autoupdate`, but with the
`ansible-lint` hook held back manually.
2021-07-19 11:33:51 -04:00
Nicholas McDonnell
2b48e75b23
Apply changes from the shfmt pre-commit hook
2021-07-14 14:34:40 -04:00
Nicholas McDonnell
406b6880bd
Replace the beautysh hook with pre-commit-shfmt
...
We have had a difficult time with how beautysh parses some shellscripts. I went
in pursuit of an alternative and I believe shfmt to be a good alternative.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
2021-07-14 14:33:52 -04:00
Nicholas McDonnell
e2a729d0b1
Install the shfmt tool for GHA
...
The `shfmt` tool does not ship on the GitHub Actions runners so we must install
it manually.
2021-07-13 17:42:36 -04:00
Shane Frasier
8ee2116f42
Prefer the newer "go install" syntax
...
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command ) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-13 17:02:13 -04:00
Shane Frasier
337d1efb8f
Capitalize Go for consistency
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-12 09:06:41 -04:00
Jeremy Frasier
bb6e566e3a
Move go installation so that it takes place before the cache task
...
Some variables defined in the go installation are used in the cache
task, so the go installation must happen first.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-11 21:59:58 -04:00
Jeremy Frasier
181d1b2faf
Install a specific version of terraform-docs
...
Note that this change is dependent on the merging of
cisagov/setup-env-github-action#31 .
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-10 22:36:45 -04:00
Jeremy Frasier
b629f7f623
Modify the Packer installation to model that of Terraform
...
The Terraform installation does not destroy the existing system
Terraform installation, and neither should the Packer installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-09 22:48:21 -04:00
Jeremy Frasier
70414cff28
Remove unnecessary line in tasks
...
There is no reason to create /usr/bin/terraform. This is a vestige of
an earlier age.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-09 22:46:47 -04:00
Shane Frasier
c481043981
Break out the curl cache creation into its own step
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
2021-07-09 22:43:09 -04:00
Jeremy Frasier
106af21c04
Install terraform and packer for the linting job
...
We should be doing this because the Packer and Terraform pre-commit
hooks leverage the corresponding executables; therefore, it makes
sense to go ahead and install the particular versions of those
executables that we support. Also add support for optionally
debugging via tmate.
See also cisagov/skeleton-generic#74 .
2021-07-09 14:56:14 -04:00
Nicholas McDonnell
d4781ee177
Add the validate_manifest hook from pre-commit
...
This hook will validate any pre-commit hook manifest files in the repository.
2021-06-24 01:38:44 -04:00
Nicholas McDonnell
f2a423095e
Add comments to markdownlint configuration
...
Now that this is a YAML file we can add comments explaining the rule
modifications we use. This will make it easier to edit or expand in the future.
2021-06-23 13:58:42 -04:00
Nicholas McDonnell
ce173f401d
Switch to a YAML markdownlint configuration file
...
This converts the existing `.mdl_config.json` file to an equivalent
`.mdl_config.yaml` file. The reference in the markdownlint pre-commit hook
configuration is updated to match.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
2021-06-23 13:57:30 -04:00
Nicholas McDonnell
afc6bd6f6d
Add rule for image headers
...
Add <h1> and <img> tags to the allowed list for MD033 (HTML elements) to
support using an image as the first thing in a markdown file (header image).
2021-06-18 03:37:08 -04:00
Nicholas McDonnell
1e8f822391
Add style enforcement rules
...
Add rules to enforce ATX-closed headers, dashes for unordered list elements,
and `1.` for ordered list elements.
2021-06-18 03:33:26 -04:00
Nick M
b0e7f014e3
Merge pull request #70 from cisagov/improvement/gitignore_me
...
Improve gitignore file comments and organization.
2021-06-02 10:56:14 -04:00
Nick M
e140c33929
Merge branch 'develop' into improvement/gitignore_me
2021-06-02 10:53:29 -04:00
Nick M
02aefa1644
Merge pull request #75 from cisagov/documentation/update_pyenv_instructions
...
Update Instructions for Configuring pyenv
2021-06-02 10:52:42 -04:00
Nick M
b486037f8b
Merge branch 'develop' into documentation/update_pyenv_instructions
2021-06-02 10:48:49 -04:00
Nick M
01b06c4e20
Merge pull request #72 from cisagov/maintenance/remove_user_from_codeowners
...
Remove User from CODEOWNERS
2021-06-02 10:48:26 -04:00
Nick M
39a67fce0f
Merge branch 'develop' into maintenance/remove_user_from_codeowners
2021-06-02 10:45:55 -04:00
Nick M
bd12db16be
Merge pull request #71 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
2021-06-02 10:45:40 -04:00
Nicholas McDonnell
23b324befc
Update configuration instructions for pyenv
...
With the release of pyenv v2.0.0 there is a breaking change around startup
logic that necessitates an update for our pyenv setup instructions. Also
add a statement about how to get configuration instructions from pyenv
itself.
2021-06-01 11:25:27 -04:00
Nicholas McDonnell
03494999d6
Update pre-commit hooks
...
Hooks updated with the `pre-commit autoupdate` command.
Note:
The `ansible-lint` hook is intentionally being held back on 4.3.7 because of
ongoing issues with the 5.x version and how we use Ansible (standalone Galaxy
roles).
2021-06-01 10:59:10 -04:00
Nicholas McDonnell
2c4d7a2504
Remove user from CODEOWNERS
...
Due to her departure this removes hillaryj from the default CODEOWNERS we use
in our projects.
2021-04-15 11:53:57 -04:00
Felddy
ba49077ab4
Improve gitignore file comments and organization.
...
* Add a comment describing what the files does.
* Add sections to organize patterns.
2021-04-12 10:37:49 -04:00
Nick M
09744fad25
Merge pull request #67 from cisagov/improvement/add_beautysh_pre-commit_hook
...
Add the beautysh pre-commit hook
2021-02-16 17:08:50 -05:00
Nick M
c025046068
Merge branch 'develop' into improvement/add_beautysh_pre-commit_hook
2021-02-16 17:07:12 -05:00
Nick M
33138501e2
Merge pull request #69 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
2021-02-16 17:06:58 -05:00
Nicholas McDonnell
c97a883ada
Revert ansible-lint version update
...
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in https://github.com/cisagov/skeleton-ansible-role/issues/69 .
2021-02-16 13:18:45 -05:00
Nicholas McDonnell
6bd93ff6fb
Update pre-commit hooks with pre-commit autoupdate
2021-02-11 13:04:14 -05:00
Nicholas McDonnell
ecdfc527d4
Add the beautysh pre-commit hook
...
This hook performs auto-formatting (beautifying) of Bash scripts.
2021-01-15 10:36:02 -05:00
Nick M
09f4f549a8
Merge pull request #65 from cisagov/improvement/enable_yamllint_strict
...
Use the --strict Flag for the yamllint pre-commit Hook
2021-01-07 11:13:43 -05:00