Jeremy Frasier
70414cff28
Remove unnecessary line in tasks
...
There is no reason to create /usr/bin/terraform. This is a vestige of
an earlier age.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Shane Frasier
c481043981
Break out the curl cache creation into its own step
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
Jeremy Frasier
106af21c04
Install terraform and packer for the linting job
...
We should be doing this because the Packer and Terraform pre-commit
hooks leverage the corresponding executables; therefore, it makes
sense to go ahead and install the particular versions of those
executables that we support. Also add support for optionally
debugging via tmate.
See also cisagov/skeleton-generic#74 .
3 years ago
Nicholas McDonnell
d4781ee177
Add the validate_manifest hook from pre-commit
...
This hook will validate any pre-commit hook manifest files in the repository.
3 years ago
Nicholas McDonnell
f2a423095e
Add comments to markdownlint configuration
...
Now that this is a YAML file we can add comments explaining the rule
modifications we use. This will make it easier to edit or expand in the future.
3 years ago
Nicholas McDonnell
ce173f401d
Switch to a YAML markdownlint configuration file
...
This converts the existing `.mdl_config.json` file to an equivalent
`.mdl_config.yaml` file. The reference in the markdownlint pre-commit hook
configuration is updated to match.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
Nicholas McDonnell
afc6bd6f6d
Add rule for image headers
...
Add <h1> and <img> tags to the allowed list for MD033 (HTML elements) to
support using an image as the first thing in a markdown file (header image).
3 years ago
Nicholas McDonnell
1e8f822391
Add style enforcement rules
...
Add rules to enforce ATX-closed headers, dashes for unordered list elements,
and `1.` for ordered list elements.
3 years ago
Nick M
b0e7f014e3
Merge pull request #70 from cisagov/improvement/gitignore_me
...
Improve gitignore file comments and organization.
3 years ago
Nick M
e140c33929
Merge branch 'develop' into improvement/gitignore_me
3 years ago
Nick M
02aefa1644
Merge pull request #75 from cisagov/documentation/update_pyenv_instructions
...
Update Instructions for Configuring pyenv
3 years ago
Nick M
b486037f8b
Merge branch 'develop' into documentation/update_pyenv_instructions
3 years ago
Nick M
01b06c4e20
Merge pull request #72 from cisagov/maintenance/remove_user_from_codeowners
...
Remove User from CODEOWNERS
3 years ago
Nick M
39a67fce0f
Merge branch 'develop' into maintenance/remove_user_from_codeowners
3 years ago
Nick M
bd12db16be
Merge pull request #71 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
Nicholas McDonnell
23b324befc
Update configuration instructions for pyenv
...
With the release of pyenv v2.0.0 there is a breaking change around startup
logic that necessitates an update for our pyenv setup instructions. Also
add a statement about how to get configuration instructions from pyenv
itself.
3 years ago
Nicholas McDonnell
03494999d6
Update pre-commit hooks
...
Hooks updated with the `pre-commit autoupdate` command.
Note:
The `ansible-lint` hook is intentionally being held back on 4.3.7 because of
ongoing issues with the 5.x version and how we use Ansible (standalone Galaxy
roles).
3 years ago
Nicholas McDonnell
2c4d7a2504
Remove user from CODEOWNERS
...
Due to her departure this removes hillaryj from the default CODEOWNERS we use
in our projects.
3 years ago
Felddy
ba49077ab4
Improve gitignore file comments and organization.
...
* Add a comment describing what the files does.
* Add sections to organize patterns.
3 years ago
Nick M
09744fad25
Merge pull request #67 from cisagov/improvement/add_beautysh_pre-commit_hook
...
Add the beautysh pre-commit hook
3 years ago
Nick M
c025046068
Merge branch 'develop' into improvement/add_beautysh_pre-commit_hook
3 years ago
Nick M
33138501e2
Merge pull request #69 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
Nicholas McDonnell
c97a883ada
Revert ansible-lint version update
...
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in https://github.com/cisagov/skeleton-ansible-role/issues/69 .
3 years ago
Nicholas McDonnell
6bd93ff6fb
Update pre-commit hooks with `pre-commit autoupdate`
3 years ago
Nicholas McDonnell
ecdfc527d4
Add the beautysh pre-commit hook
...
This hook performs auto-formatting (beautifying) of Bash scripts.
3 years ago
Nick M
09f4f549a8
Merge pull request #65 from cisagov/improvement/enable_yamllint_strict
...
Use the --strict Flag for the yamllint pre-commit Hook
3 years ago
Nick M
9d909dacd8
Merge branch 'develop' into improvement/enable_yamllint_strict
3 years ago
Nick M
23838191be
Merge pull request #64 from cisagov/improvement/add_pre-commit-packer
...
Add the pre-commit-packer Repo and Hooks to the pre-commit Configuration
3 years ago
Nick M
be43230b7b
Merge branch 'develop' into improvement/add_pre-commit-packer
3 years ago
Nick M
01e3f843c9
Merge pull request #63 from cisagov/pre-commit_hook_maintenance
...
pre-commit Hook Maintenance and Update
3 years ago
Nicholas McDonnell
2fb4e15cf6
Add the --strict flag to the yamllint pre-commot hook
...
The --strict flag will cause the yamllint hook to exit with a non-zero exit
code when warnings are found instead of only when errors are found.
3 years ago
Nicholas McDonnell
8f7435a6fa
Add the pre-commit-packer repo and hooks
3 years ago
Nicholas McDonnell
362b054459
Run pre-commit autoupdate
3 years ago
Nicholas McDonnell
46ec3e7002
Update ansible-lint hook URL
3 years ago
Nicholas McDonnell
d836e91d32
Update repo URL for the isort hook
...
I missed that this repository was transfered from the creator, Timothy Crosley,
to the PyCQA organization.
3 years ago
Nicholas McDonnell
06159cbb65
Run pre-commit autoupdate
3 years ago
Nicholas McDonnell
a7f86ddad0
Enable two additional hooks from default pre-commit-hooks
...
Enabled 'check-case-conflict' because of our mixed Linux and macOS development.
Although APFS supports case-sensitive containers, it is not the default as far
as I am aware. Linux filesystems are typically case-sensitive however.
With the merge of https://github.com/cisagov/development-guide/pull/42 we now
have a TOML file in a repository, so it does not hurt to add this hook in case
more are added in the future.
3 years ago
Nicholas McDonnell
5115baee52
Remove trailing '.git's from repository URLs
...
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we
should be consistent in how we format things.
3 years ago
Nicholas McDonnell
2d6bf50eab
Update black hook repo url
...
At some point the python GitHub organization renamed to psf (Python Software
Foundation). Although it redirects with no issue, I think it should be updated
to reflect the current repository URL.
3 years ago
Nicholas McDonnell
b769825c41
Update prettier hook details
...
Per https://github.com/prettier/prettier/pull/8937 the pre-commit hook has
been moved to https://github.com/pre-commit/mirrors-prettier . I have also
updated to the latest version in that repository.
3 years ago
Nick M
df674df714
Merge pull request #62 from cisagov/improvement/clean_up_actions/cache
...
Improve actions/cache Configuration
4 years ago
Nicholas McDonnell
f4131e57d8
Clean up our actions/cache step
...
Removed name because it was not more informative than the default. Swapped out
a hardcoded job reference for the github.job context value. Switch the base
cache key to a step environment value so we can set it once and reuse. Removed
additional restore-key value that might have undesirable results.
4 years ago
Shane Frasier
3b312c43d4
Merge pull request #59 from cisagov/improvement/get-python-version-more-simply
...
Use the python version output by actions/setup-python
4 years ago
Shane Frasier
b638143238
Merge branch 'develop' into improvement/get-python-version-more-simply
4 years ago
Shane Frasier
2a2067f1c7
Merge pull request #57 from cisagov/improvement/insist-that-devs-own-gihub-dir
...
Ensure that the cisagov devs are the owners of the .github directory
4 years ago
Shane Frasier
1310cfd468
Merge branch 'develop' into improvement/insist-that-devs-own-gihub-dir
4 years ago
Nick M
763d2474c7
Merge pull request #60 from cisagov/organize_pre-commit_requirements
...
Organize and Sort pre-commit Hooks
4 years ago
Nicholas McDonnell
64c3fb61ab
Organize pre-commit hooks
...
Group related pre-commit hooks together. Make sure that hooks are
alphabetically sorted within those groups.
4 years ago
Jeremy Frasier
02c5a6f8bf
Use the python version output by actions/setup-python
...
There is no need to run python code to determine the python version.
Resolves #58 .
See here for details:
https://github.com/actions/setup-python/blob/main/action.yml#L14-L16
4 years ago
Jeremy Frasier
5b199bc869
Remove offending slash
...
Thanks to @dav3r and @mcdonnnj for the suggestion.
4 years ago