Nick M
c025046068
Merge branch 'develop' into improvement/add_beautysh_pre-commit_hook
2021-02-16 17:07:12 -05:00
Nicholas McDonnell
c97a883ada
Revert ansible-lint version update
...
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in https://github.com/cisagov/skeleton-ansible-role/issues/69 .
2021-02-16 13:18:45 -05:00
Nicholas McDonnell
6bd93ff6fb
Update pre-commit hooks with pre-commit autoupdate
2021-02-11 13:04:14 -05:00
Nicholas McDonnell
ecdfc527d4
Add the beautysh pre-commit hook
...
This hook performs auto-formatting (beautifying) of Bash scripts.
2021-01-15 10:36:02 -05:00
Nick M
9d909dacd8
Merge branch 'develop' into improvement/enable_yamllint_strict
2021-01-07 11:10:05 -05:00
Nick M
be43230b7b
Merge branch 'develop' into improvement/add_pre-commit-packer
2021-01-07 11:06:07 -05:00
Nicholas McDonnell
2fb4e15cf6
Add the --strict flag to the yamllint pre-commot hook
...
The --strict flag will cause the yamllint hook to exit with a non-zero exit
code when warnings are found instead of only when errors are found.
2021-01-07 04:07:38 -05:00
Nicholas McDonnell
8f7435a6fa
Add the pre-commit-packer repo and hooks
2020-12-31 15:09:53 -05:00
Nicholas McDonnell
362b054459
Run pre-commit autoupdate
2020-12-31 15:08:07 -05:00
Nicholas McDonnell
46ec3e7002
Update ansible-lint hook URL
2020-12-31 15:06:18 -05:00
Nicholas McDonnell
d836e91d32
Update repo URL for the isort hook
...
I missed that this repository was transfered from the creator, Timothy Crosley,
to the PyCQA organization.
2020-12-17 13:50:34 -05:00
Nicholas McDonnell
06159cbb65
Run pre-commit autoupdate
2020-12-16 18:30:17 -05:00
Nicholas McDonnell
a7f86ddad0
Enable two additional hooks from default pre-commit-hooks
...
Enabled 'check-case-conflict' because of our mixed Linux and macOS development.
Although APFS supports case-sensitive containers, it is not the default as far
as I am aware. Linux filesystems are typically case-sensitive however.
With the merge of https://github.com/cisagov/development-guide/pull/42 we now
have a TOML file in a repository, so it does not hurt to add this hook in case
more are added in the future.
2020-12-16 18:21:03 -05:00
Nicholas McDonnell
5115baee52
Remove trailing '.git's from repository URLs
...
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we
should be consistent in how we format things.
2020-12-16 18:15:03 -05:00
Nicholas McDonnell
2d6bf50eab
Update black hook repo url
...
At some point the python GitHub organization renamed to psf (Python Software
Foundation). Although it redirects with no issue, I think it should be updated
to reflect the current repository URL.
2020-12-16 18:13:04 -05:00
Nicholas McDonnell
b769825c41
Update prettier hook details
...
Per https://github.com/prettier/prettier/pull/8937 the pre-commit hook has
been moved to https://github.com/pre-commit/mirrors-prettier . I have also
updated to the latest version in that repository.
2020-12-16 18:03:13 -05:00
Nicholas McDonnell
64c3fb61ab
Organize pre-commit hooks
...
Group related pre-commit hooks together. Make sure that hooks are
alphabetically sorted within those groups.
2020-11-15 23:02:59 -05:00
Nicholas McDonnell
919460cb21
Change repo for the prettier pre-commit hook
...
Per https://github.com/prettier/prettier/issues/9459 and specifically
https://github.com/prettier/prettier/issues/9459#issuecomment-713223710
the prettier hook for pre-commit is being broken out into its own repo.
2020-10-22 13:42:10 -04:00
Nicholas McDonnell
59eef4cc77
Run pre-commit autoupdate
2020-10-19 11:53:09 -04:00
Nicholas McDonnell
b5ef97dd4b
Remove seed-isort-config pre-commit hook
...
As of isort >=5, which we use, the seed-isort-config hook has been deprecated,
and the repository archived. I have removed the hook and the configuration
options it updated as a result.
2020-10-19 11:49:41 -04:00
Nicholas McDonnell
332e5a7669
Run pre-commit autoupdate
2020-09-03 16:27:01 -04:00
Nicholas McDonnell
91279d3ac2
Perform a pre-commit autoupdate for 2020-07
...
Notable version changes:
- docker-pre-commit v2.0.0
This release includes the addition of two new hooks: hadolint and
hadolint-system. These allow for linting Dockerfiles with the hadolint
Docker image or a system installation of hadolint respectively.
- isort 5.0.7
This release takes us from isort 4 to isort 5. There are a multitude of
changes with information available on the isort 5 release page at
https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/
The most notable feature for us is the addition of built-in profiles for
isort to run under. These profiles provide settings for conforming to various
popular styles, and black is one of the profiles.
2020-07-10 21:28:58 -04:00
Nicholas McDonnell
f831ef827c
Add final statement to descriptionf or why terraform_validate is disabled.
...
Review noticed that there lacked a determination for what we were doing about
the problem with the terraform_validate hook. I described the problems but
failed to mention what our path forward would be. This commit rectifies that
oversight.
2020-05-13 21:34:58 -04:00
Nicholas McDonnell
fe4d5eb72a
Disable the terraform_validate hook.
...
We have seen a number of issues related to this hook ever since it was
re-enabled. It will need to remain disabled until at least the 0.13 Terraform
release, and can only be re-enabled if all issues we have seen have been
resolved in how `terraform validate` operates.
2020-05-13 16:07:18 -04:00
Nicholas McDonnell
2399f24622
Remove legacy comment from the isort hook declaration.
...
This comment references the mirrors-isort repository that we are no longer
using.
2020-05-13 15:35:36 -04:00
Nicholas McDonnell
daaebc1cc1
Ran pre-commit autoupdate.
2020-05-13 15:30:04 -04:00
Nicholas McDonnell
ce6658abc6
Update isort pre-commit hook source repository.
...
The mirrors-isort respository has been deprecated per this Pull Request:
https://github.com/pre-commit/mirrors-isort/pull/13
Since isort includes pre-commit configuration in current versions we will
switch to using it directly.
2020-05-13 15:25:31 -04:00
Nicholas McDonnell
7d7a677457
Updated pre-commit configuration with 'pre-commit autoupdate'.
2020-05-08 17:49:17 -04:00
Nicholas McDonnell
0bc1aab45e
Ran pre-commit autoupdate to get the latest version of the
...
`pre-commit-terraform` hook since the PR I submitted,
https://github.com/antonbabenko/pre-commit-terraform/pull/100 ,
was approved. This will fix issues with `skeleton-tf-module` related to multiple
directories with Terraform code.
2020-04-06 12:05:57 -04:00
Nicholas McDonnell
61790a9bbd
Fixed broken hook id for pre-commit-terraform:
...
terraform_validate_no_variables was changed to terraform_validate in the
following commit:
35e0356188
2020-03-31 14:41:10 -04:00
Felddy
067ee0850c
Autoupdate pre-commit hooks. Add mypy.
2020-02-20 22:14:08 -05:00
Nicholas McDonnell
b857939b3d
Run pre-commit autoupdate.
2020-02-12 00:01:16 -05:00
Nicholas McDonnell
18b5d12c78
Add seed-isort-config and isort to pre-commit hooks.
...
Add isort configuration file.
2019-12-19 15:32:36 -05:00
Felddy
30a16a3842
Autoupdate pre-commit hooks.
2019-11-15 11:51:46 -05:00
Felddy
7c0b30b495
Force pre-commit hooks to use python3.
...
Fixes #23
2019-11-15 11:50:38 -05:00
Nicholas McDonnell
3c78dd98a6
Re-enabled ansible-lint and ran pre-commit autoupgrade.
2019-11-02 19:48:42 -04:00
Felddy
b31ad8591f
Disable ansible-lint until they fix their setup.py
...
See: https://github.com/ansible/ansible-lint/issues/590
2019-10-18 10:46:32 -04:00
Dave Redmin
78a230d46c
Add updates from running pre-commit autoupdate
2019-10-18 10:10:19 -04:00
Jeremy Frasier
2932d35483
Add updates from running pre-commit autoupdate
2019-09-11 15:58:44 -04:00
Jeremy Frasier
3fee0b8687
Rename LICENSE.md to LICENSE, make the other changes that requires
...
The license text is not actually in Markdown, and adding the .md
extension actually makes it render a little differently than intended.
2019-06-24 17:17:54 -04:00
Jeremy Frasier
1843ca0b48
Add config file for markdownlint
...
This config file turns off the "line too long" rule when within a code
block or a table. Often there is no way to avoid going over 80 lines
in such cases.
2019-06-24 17:14:02 -04:00
Jeremy Frasier
a13597d233
Update pre-commit hooks via pre-commit autoupdate
2019-06-24 17:11:45 -04:00
Jeremy Frasier
740457694a
Remove the terraform-docs hook
...
terraform-docs is currently broken with respect to terraform 0.12.
2019-06-06 16:33:07 -04:00
Jeremy Frasier
b58fa62c00
Add changes from running pre-commit autoupdate
2019-06-06 16:12:58 -04:00
Jeremy Frasier
4e9280eb2b
Update pre-commit plugins to latest versions
...
Via pre-commit autoupdate.
2019-05-26 11:57:27 -04:00
Jeremy Frasier
19afa70f67
Run pre-commit autoupdate
...
Also update the URL for black since it moved GitHub orgs from ambv to
python.
2019-05-06 10:44:34 -04:00
Felddy
6a64a512e4
Add a configuration file for Bandit, and configure pre-commit to use it.
2019-05-03 16:49:35 -04:00
Jeremy Frasier
8e0b1d7386
Add pydoc warnings to flake8 config
...
Also add flake8-docstrings as an additional dependency in the
.pre-commit-config.yml file.
2019-05-03 14:30:56 -04:00
Jeremy Frasier
953752e41a
Add bandit pre-commit hook
...
Also ran pre-commit autoupdate, which picked up a newer version of the
pyupgrade hook.
2019-04-03 22:51:50 -04:00
Jeremy Frasier
74e145257c
Remove black and pyupgrade from requirements-test
...
They are not needed there.
Also run pre-commit autoupdate to pick up the latest version of hooks.
2019-03-30 12:47:36 -04:00
