af06915b05
Add tool and docs to automate development environment setup.
4 years ago
6668e3b465
Merge pull request #45 from cisagov/improvement/add-wheel
...
Add setuptools and wheel as pip dependencies
4 years ago
7f8d430a30
Pull in requirements.txt from requirements-test.txt
4 years ago
87ea53022c
Add setuptools and wheel as pip dependencies
...
setuptools usually comes along with pip, but wheel does not. Using
wheel where possible to build python extensions is more modern and
more security conscious than using setup.py.
4 years ago
70f0cbd612
Merge pull request #44 from cisagov/improvements/pre-commit_autoupdate_2020-05
...
Update pre-commit Hook Versions
4 years ago
64edcc22a7
Merge branch 'improvements/pre-commit_autoupdate_2020-05' of github.com:cisagov/skeleton-generic into improvements/pre-commit_autoupdate_2020-05
4 years ago
f831ef827c
Add final statement to descriptionf or why terraform_validate is disabled.
...
Review noticed that there lacked a determination for what we were doing about
the problem with the terraform_validate hook. I described the problems but
failed to mention what our path forward would be. This commit rectifies that
oversight.
4 years ago
4d4db071b8
Merge branch 'develop' into improvements/pre-commit_autoupdate_2020-05
4 years ago
fe4d5eb72a
Disable the terraform_validate hook.
...
We have seen a number of issues related to this hook ever since it was
re-enabled. It will need to remain disabled until at least the 0.13 Terraform
release, and can only be re-enabled if all issues we have seen have been
resolved in how `terraform validate` operates.
4 years ago
2399f24622
Remove legacy comment from the isort hook declaration.
...
This comment references the mirrors-isort repository that we are no longer
using.
4 years ago
daaebc1cc1
Ran pre-commit autoupdate.
4 years ago
ce6658abc6
Update isort pre-commit hook source repository.
...
The mirrors-isort respository has been deprecated per this Pull Request:
https://github.com/pre-commit/mirrors-isort/pull/13
Since isort includes pre-commit configuration in current versions we will
switch to using it directly.
4 years ago
7d7a677457
Updated pre-commit configuration with 'pre-commit autoupdate'.
4 years ago
3301dfa04f
Merge pull request #43 from cisagov/improvement/apb-events
...
Allow events from apb to rebuild this repository weekly.
4 years ago
8c99c5294a
Allow events from apb to rebuild this repository weekly.
4 years ago
175ae71602
Merge pull request #42 from cisagov/hillaryj-owner
...
Update CODEOWNERS
4 years ago
c8b4bcf126
Update CODEOWNERS
4 years ago
89b098aefc
Merge pull request #41 from cisagov/bugfix/update_pre-commit_for_pre-commit-terraform_hook
...
Update pre-commit Hooks to Include Bugfix
4 years ago
647b351997
Sort .gitignore entries.
4 years ago
1f3d440a1a
Rename action to accurately reflect that we are only linting, not building.
...
Adjust description for pre-commit hook setup to better convey what is being
done.
4 years ago
b01a0ee7bd
Explicitly install pre-commit hooks as its own step so it's clearer when the
...
failure is with setup rather than hooks running.
4 years ago
0bc1aab45e
Ran `pre-commit autoupdate` to get the latest version of the
...
`pre-commit-terraform` hook since the PR I submitted,
https://github.com/antonbabenko/pre-commit-terraform/pull/100 ,
was approved. This will fix issues with `skeleton-tf-module` related to multiple
directories with Terraform code.
4 years ago
757a861864
Merge pull request #40 from cisagov/improvements/update_pre-commit
...
Update pre-commit Hooks and Fix Broken Hook ID
4 years ago
61790a9bbd
Fixed broken hook id for pre-commit-terraform:
...
terraform_validate_no_variables was changed to terraform_validate in the
following commit:
35e0356188
4 years ago
f5fd431b45
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
...
Add markdownlint Configuration Option for MD024
4 years ago
d791334352
Add a rule for markdownlint to allow multiple headers with the same name as long
...
as they are not nested in the same heading group.
4 years ago
241484abe4
Merge pull request #38 from cisagov/change_cache_paths_to_env_variables
...
Change Cache Paths to Environment Variables
4 years ago
478f1688a1
Change the cache paths from hardcoded values in their appropriate blocks to environment variables declared before the job block.
4 years ago
b58f7a1546
Merge pull request #37 from cisagov/add_python_version_to_cache_keys
...
Incorporate the Python version into keys for pip and pre-commit caches.
4 years ago
454864bc02
Incorporate the Python version into keys for pip and pre-commit caches.
...
This should resolve the issue seen when the Python version changes before there
is an update to .pre-commit-config.yml which results in pre-commit pointing to
a non-existent Python installation.
4 years ago
c7f339fb84
Merge pull request #36 from cisagov/improvement/add-mypy-cache-to-gitignore
...
Add .mypy_cache to .gitignore
4 years ago
bf366086f4
Add .mypy_cache to .gitignore
4 years ago
6369cc6594
Merge pull request #35 from cisagov/improvement/static_type_checking
...
Autoupdate pre-commit hooks. Add mypy.
4 years ago
067ee0850c
Autoupdate pre-commit hooks. Add mypy.
4 years ago
a17986bdae
Merge pull request #34 from cisagov/improvements/use_verbose_pip_switches
...
Use Verbose pip Switches
4 years ago
e96577bce4
All references to '-r' for pip calls have been replaced with the more verbose '--requirement'.
4 years ago
16872bfc74
Merge pull request #33 from cisagov/improvement/update_pre-commit_hooks
...
Update pre-commit hooks (and flip Actions cache order in workflow).
4 years ago
d99fd00bc2
Flip cache order to mirror how it is done downstream.
4 years ago
b857939b3d
Run pre-commit autoupdate.
4 years ago
8116a89b8c
Merge pull request #32 from cisagov/improvements/update_python_version_and_checkout_action
...
Update Python and actions/checkout Versions
4 years ago
f7a4166ad6
Update Python version used to 3.8
...
Update actions/checkout to v2
Update formatting to match downstream children
4 years ago
3f6d654ad6
Merge pull request #31 from cisagov/improvements/add_wsl_instructions
...
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
4 years ago
532751627a
Backported changes to CONTRIBUTING.md from the development guide.
4 years ago
a8e35d0fed
Merge pull request #29 from cisagov/improvement/better-handle-prs-from-forked-repos
...
Make workflow run when a PR is opened, synchronized, or reopened
4 years ago
dbd589d2e2
Improve list formatting
4 years ago
2fa4cbe194
Make workflow run when a PR is opened, synchronized, or reopened
...
A user forked cisagov/scan-target-data and created a pull request, but
the required GitHub Action(s) did not run. This is presumably because
the user does not have Actions enabled in his or her fork. Ideally,
the required Action(s) would run in cisagov/scan-target-data when a PR
to merge changes back is created. Based on my reading of this link,
adding the "pull_request" event type should make this happen:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
4 years ago
09afdf3a7c
Merge pull request #28 from cisagov/improvements/pre-commit_add_isort
...
Add isort tool to pre-commit hooks.
4 years ago
18b5d12c78
Add seed-isort-config and isort to pre-commit hooks.
...
Add isort configuration file.
4 years ago
b89eecb788
Update CODEOWNERS
5 years ago
3f9376036c
Merge pull request #25 from cisagov/improvement/codeowners
...
Add codeowners file with team OIS maintainers.
5 years ago
Felddy
Shane Frasier
Jeremy Frasier
Nick M
Mark Feldhousen
Hillary