Nicholas McDonnell
5115baee52
Remove trailing '.git's from repository URLs
...
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we
should be consistent in how we format things.
2020-12-16 18:15:03 -05:00
Nicholas McDonnell
2d6bf50eab
Update black hook repo url
...
At some point the python GitHub organization renamed to psf (Python Software
Foundation). Although it redirects with no issue, I think it should be updated
to reflect the current repository URL.
2020-12-16 18:13:04 -05:00
Nicholas McDonnell
b769825c41
Update prettier hook details
...
Per https://github.com/prettier/prettier/pull/8937 the pre-commit hook has
been moved to https://github.com/pre-commit/mirrors-prettier . I have also
updated to the latest version in that repository.
2020-12-16 18:03:13 -05:00
Nick M
df674df714
Merge pull request #62 from cisagov/improvement/clean_up_actions/cache
...
Improve actions/cache Configuration
2020-12-03 10:18:06 -05:00
Nicholas McDonnell
f4131e57d8
Clean up our actions/cache step
...
Removed name because it was not more informative than the default. Swapped out
a hardcoded job reference for the github.job context value. Switch the base
cache key to a step environment value so we can set it once and reuse. Removed
additional restore-key value that might have undesirable results.
2020-11-20 12:22:39 -05:00
Shane Frasier
3b312c43d4
Merge pull request #59 from cisagov/improvement/get-python-version-more-simply
...
Use the python version output by actions/setup-python
2020-11-18 11:50:11 -05:00
Shane Frasier
b638143238
Merge branch 'develop' into improvement/get-python-version-more-simply
2020-11-18 11:48:22 -05:00
Shane Frasier
2a2067f1c7
Merge pull request #57 from cisagov/improvement/insist-that-devs-own-gihub-dir
...
Ensure that the cisagov devs are the owners of the .github directory
2020-11-18 11:48:13 -05:00
Shane Frasier
1310cfd468
Merge branch 'develop' into improvement/insist-that-devs-own-gihub-dir
2020-11-18 11:46:43 -05:00
Nick M
763d2474c7
Merge pull request #60 from cisagov/organize_pre-commit_requirements
...
Organize and Sort pre-commit Hooks
2020-11-18 11:42:16 -05:00
Nicholas McDonnell
64c3fb61ab
Organize pre-commit hooks
...
Group related pre-commit hooks together. Make sure that hooks are
alphabetically sorted within those groups.
2020-11-15 23:02:59 -05:00
Jeremy Frasier
02c5a6f8bf
Use the python version output by actions/setup-python
...
There is no need to run python code to determine the python version.
Resolves #58 .
See here for details:
https://github.com/actions/setup-python/blob/main/action.yml#L14-L16
2020-11-10 22:22:15 -05:00
Jeremy Frasier
5b199bc869
Remove offending slash
...
Thanks to @dav3r and @mcdonnnj for the suggestion.
2020-11-03 14:51:18 -05:00
Jeremy Frasier
a842abbfef
Insist that the cisagov devs are the owners of the .github directory
...
This additional clause must remain at the _end_ of the CODEOWNERS file
so that it cannot be overridden by a later clause.
We want to make it so that all the .github files including CODEOWNERS
are protected so only code owners (the dev team) can approve
modifications to them.
This will prevent configuration changes from breaking Actions and
other management-type functions that the files in this directory
control. By setting the .github files/folder to require code owner
approval for changes, workflow and management changes will require dev
team review and checking.
Resolves #56 .
2020-11-03 12:46:39 -05:00
Nick M
e44762c82f
Merge pull request #55 from cisagov/migrate_prettier_hook
...
Change repo for the prettier pre-commit hook
2020-10-22 13:54:40 -04:00
Nicholas McDonnell
919460cb21
Change repo for the prettier pre-commit hook
...
Per https://github.com/prettier/prettier/issues/9459 and specifically
https://github.com/prettier/prettier/issues/9459#issuecomment-713223710
the prettier hook for pre-commit is being broken out into its own repo.
2020-10-22 13:42:10 -04:00
Nick M
4d88e06e99
Merge pull request #54 from cisagov/pre-commit_updates
...
Update pre-commit Hooks
2020-10-22 10:48:16 -04:00
Nick M
1928db67bc
Merge branch 'develop' into pre-commit_updates
2020-10-22 10:44:39 -04:00
Nick M
a9ef644774
Merge pull request #53 from cisagov/add-how-to-skeleton
...
Add link to how to set up a new repo with skeletons
2020-10-22 10:44:26 -04:00
Nicholas McDonnell
59eef4cc77
Run pre-commit autoupdate
2020-10-19 11:53:09 -04:00
Nicholas McDonnell
de409db3f7
Use local filename in README link
2020-10-19 11:52:09 -04:00
Nicholas McDonnell
b5ef97dd4b
Remove seed-isort-config pre-commit hook
...
As of isort >=5, which we use, the seed-isort-config hook has been deprecated,
and the repository archived. I have removed the hook and the configuration
options it updated as a result.
2020-10-19 11:49:41 -04:00
Hillary
57d927d7d1
Add line breaks for linting
...
Pre-commit is now installed properly.
2020-10-09 10:10:12 -04:00
Hillary
e14ecde029
Add link to how to set up a new repo with skeletons
2020-10-09 10:07:04 -04:00
Mark Feldhousen
0923631e27
Merge pull request #52 from cisagov/improvement/workflows
...
Workflow improvements: 🦁 set-env, and 🐯 python-3.9, and 🐻 dependabot, oh my!
2020-10-07 13:53:37 -04:00
Felddy
7389a1b0cf
Enable weekly dependabot scans of github-actions and pip
2020-10-07 12:43:54 -04:00
Felddy
c9c00f1d03
Replace deprecated set-env workflow syntax
...
See:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-07 12:42:59 -04:00
Felddy
6a4164dfba
Bump build workflow python-version to 3.9
2020-10-07 12:41:47 -04:00
Nick M
15411447a6
Merge pull request #51 from cisagov/pre-commit_updates
...
Autoupdate pre-commit and Additional Maintenance
2020-09-04 10:06:54 -04:00
Nicholas McDonnell
d8f14e845b
Sort .gitignore while I'm here
2020-09-03 16:32:30 -04:00
Nicholas McDonnell
ae4aa123c8
Update lint job to resolve #49
2020-09-03 16:31:23 -04:00
Nicholas McDonnell
3e9441c837
Update CODEOWNERS to resolve #50
2020-09-03 16:29:38 -04:00
Nicholas McDonnell
332e5a7669
Run pre-commit autoupdate
2020-09-03 16:27:01 -04:00
Nick M
e0fbcdad8a
Merge pull request #48 from cisagov/improvement/switch_setup-python_and_cache_actions_to_v2
...
Update actions/cache and actions/setup-python to v2
2020-07-30 14:04:07 -04:00
Nicholas McDonnell
969efdd0bb
Adjust cache key name
...
Make the job name the first part of the cache key since
it is the only part that isn't variable.
2020-07-30 11:08:22 -04:00
Nicholas McDonnell
6ab69f4f51
Bump actions/setup-python to v2
...
Keep it up-to-date even though we are not currently
using features added in v2.
2020-07-30 02:21:04 -04:00
Nicholas McDonnell
d6fe79dce3
Update actions/cache to v2
...
Switch the workflow to use cachev2. This puts us up to
date and allows us to consolidate into one cache item.
2020-07-30 02:19:02 -04:00
Nick M
3634093132
Merge pull request #47 from cisagov/improvement/autoupdate_pre-commit
...
Autoupdates to pre-commit Hooks for 2020-07
2020-07-13 08:48:49 -04:00
Nicholas McDonnell
907b89a20b
Add the black profile to the isort configuration
2020-07-10 21:34:22 -04:00
Nicholas McDonnell
91279d3ac2
Perform a pre-commit autoupdate for 2020-07
...
Notable version changes:
- docker-pre-commit v2.0.0
This release includes the addition of two new hooks: hadolint and
hadolint-system. These allow for linting Dockerfiles with the hadolint
Docker image or a system installation of hadolint respectively.
- isort 5.0.7
This release takes us from isort 4 to isort 5. There are a multitude of
changes with information available on the isort 5 release page at
https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/
The most notable feature for us is the addition of built-in profiles for
isort to run under. These profiles provide settings for conforming to various
popular styles, and black is one of the profiles.
2020-07-10 21:28:58 -04:00
Mark Feldhousen
174d55b782
Merge pull request #46 from cisagov/improvement/setup_env
...
setup-env: A tool to automate a development environment setup.
2020-06-22 17:44:02 -04:00
Felddy
db362b9125
Normalize quotes.
2020-06-22 17:37:34 -04:00
Felddy
31980ed4a8
Clean up usage syntax since we now have multiple options.
2020-06-22 17:18:19 -04:00
Felddy
996ae2677a
Add recommendation to install brew, instead of assuming it is available.
2020-06-22 17:13:51 -04:00
Felddy
466ef0cce5
Sort command line flag case statement.
2020-06-22 17:05:19 -04:00
Felddy
482a370679
Switch to a POSIX compliant command... command.
...
This is the way.
I learned something today.
https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then
2020-06-22 17:02:03 -04:00
Felddy
c5e7edf46b
Add flag to install pre-commit hooks now.
2020-06-22 16:55:34 -04:00
Felddy
ae21af1084
Improve usage message.
2020-06-22 16:55:01 -04:00
Felddy
8a105ca040
Respect customs.
2020-06-22 16:50:42 -04:00
Felddy
5d1d134c88
Change to python3 to standardize how we call python.
2020-06-22 16:34:53 -04:00
