Nick M
15411447a6
Merge pull request #51 from cisagov/pre-commit_updates
...
Autoupdate pre-commit and Additional Maintenance
2020-09-04 10:06:54 -04:00
Nicholas McDonnell
d8f14e845b
Sort .gitignore while I'm here
2020-09-03 16:32:30 -04:00
Nicholas McDonnell
ae4aa123c8
Update lint job to resolve #49
2020-09-03 16:31:23 -04:00
Nicholas McDonnell
3e9441c837
Update CODEOWNERS to resolve #50
2020-09-03 16:29:38 -04:00
Nicholas McDonnell
332e5a7669
Run pre-commit autoupdate
2020-09-03 16:27:01 -04:00
Nick M
e0fbcdad8a
Merge pull request #48 from cisagov/improvement/switch_setup-python_and_cache_actions_to_v2
...
Update actions/cache and actions/setup-python to v2
2020-07-30 14:04:07 -04:00
Nicholas McDonnell
969efdd0bb
Adjust cache key name
...
Make the job name the first part of the cache key since
it is the only part that isn't variable.
2020-07-30 11:08:22 -04:00
Nicholas McDonnell
6ab69f4f51
Bump actions/setup-python to v2
...
Keep it up-to-date even though we are not currently
using features added in v2.
2020-07-30 02:21:04 -04:00
Nicholas McDonnell
d6fe79dce3
Update actions/cache to v2
...
Switch the workflow to use cachev2. This puts us up to
date and allows us to consolidate into one cache item.
2020-07-30 02:19:02 -04:00
Nick M
3634093132
Merge pull request #47 from cisagov/improvement/autoupdate_pre-commit
...
Autoupdates to pre-commit Hooks for 2020-07
2020-07-13 08:48:49 -04:00
Nicholas McDonnell
907b89a20b
Add the black profile to the isort configuration
2020-07-10 21:34:22 -04:00
Nicholas McDonnell
91279d3ac2
Perform a pre-commit autoupdate for 2020-07
...
Notable version changes:
- docker-pre-commit v2.0.0
This release includes the addition of two new hooks: hadolint and
hadolint-system. These allow for linting Dockerfiles with the hadolint
Docker image or a system installation of hadolint respectively.
- isort 5.0.7
This release takes us from isort 4 to isort 5. There are a multitude of
changes with information available on the isort 5 release page at
https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/
The most notable feature for us is the addition of built-in profiles for
isort to run under. These profiles provide settings for conforming to various
popular styles, and black is one of the profiles.
2020-07-10 21:28:58 -04:00
Mark Feldhousen
174d55b782
Merge pull request #46 from cisagov/improvement/setup_env
...
setup-env: A tool to automate a development environment setup.
2020-06-22 17:44:02 -04:00
Felddy
db362b9125
Normalize quotes.
2020-06-22 17:37:34 -04:00
Felddy
31980ed4a8
Clean up usage syntax since we now have multiple options.
2020-06-22 17:18:19 -04:00
Felddy
996ae2677a
Add recommendation to install brew, instead of assuming it is available.
2020-06-22 17:13:51 -04:00
Felddy
466ef0cce5
Sort command line flag case statement.
2020-06-22 17:05:19 -04:00
Felddy
482a370679
Switch to a POSIX compliant command... command.
...
This is the way.
I learned something today.
https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then
2020-06-22 17:02:03 -04:00
Felddy
c5e7edf46b
Add flag to install pre-commit hooks now.
2020-06-22 16:55:34 -04:00
Felddy
ae21af1084
Improve usage message.
2020-06-22 16:55:01 -04:00
Felddy
8a105ca040
Respect customs.
2020-06-22 16:50:42 -04:00
Felddy
5d1d134c88
Change to python3 to standardize how we call python.
2020-06-22 16:34:53 -04:00
Felddy
23ef29c8a3
Clarify comment with text from pyenv local --help
2020-06-22 16:30:46 -04:00
Felddy
3c2781c8cc
Correct syntax on fence.
...
Closes CVE-2020-3.14159
2020-06-22 15:25:59 -04:00
Felddy
c50094a8de
Fix typo.
2020-06-22 15:15:18 -04:00
Felddy
af06915b05
Add tool and docs to automate development environment setup.
2020-06-22 14:57:04 -04:00
Shane Frasier
6668e3b465
Merge pull request #45 from cisagov/improvement/add-wheel
...
Add setuptools and wheel as pip dependencies
2020-06-09 19:40:36 -04:00
Jeremy Frasier
7f8d430a30
Pull in requirements.txt from requirements-test.txt
2020-06-09 15:19:05 -04:00
Jeremy Frasier
87ea53022c
Add setuptools and wheel as pip dependencies
...
setuptools usually comes along with pip, but wheel does not. Using
wheel where possible to build python extensions is more modern and
more security conscious than using setup.py.
2020-06-09 15:10:11 -04:00
Nick M
70f0cbd612
Merge pull request #44 from cisagov/improvements/pre-commit_autoupdate_2020-05
...
Update pre-commit Hook Versions
2020-05-14 11:33:00 -04:00
Nicholas McDonnell
64edcc22a7
Merge branch 'improvements/pre-commit_autoupdate_2020-05' of github.com:cisagov/skeleton-generic into improvements/pre-commit_autoupdate_2020-05
2020-05-13 21:36:47 -04:00
Nicholas McDonnell
f831ef827c
Add final statement to descriptionf or why terraform_validate is disabled.
...
Review noticed that there lacked a determination for what we were doing about
the problem with the terraform_validate hook. I described the problems but
failed to mention what our path forward would be. This commit rectifies that
oversight.
2020-05-13 21:34:58 -04:00
Nick M
4d4db071b8
Merge branch 'develop' into improvements/pre-commit_autoupdate_2020-05
2020-05-13 16:18:48 -04:00
Nicholas McDonnell
fe4d5eb72a
Disable the terraform_validate hook.
...
We have seen a number of issues related to this hook ever since it was
re-enabled. It will need to remain disabled until at least the 0.13 Terraform
release, and can only be re-enabled if all issues we have seen have been
resolved in how `terraform validate` operates.
2020-05-13 16:07:18 -04:00
Nicholas McDonnell
2399f24622
Remove legacy comment from the isort hook declaration.
...
This comment references the mirrors-isort repository that we are no longer
using.
2020-05-13 15:35:36 -04:00
Nicholas McDonnell
daaebc1cc1
Ran pre-commit autoupdate.
2020-05-13 15:30:04 -04:00
Nicholas McDonnell
ce6658abc6
Update isort pre-commit hook source repository.
...
The mirrors-isort respository has been deprecated per this Pull Request:
https://github.com/pre-commit/mirrors-isort/pull/13
Since isort includes pre-commit configuration in current versions we will
switch to using it directly.
2020-05-13 15:25:31 -04:00
Nicholas McDonnell
7d7a677457
Updated pre-commit configuration with 'pre-commit autoupdate'.
2020-05-08 17:49:17 -04:00
Mark Feldhousen
3301dfa04f
Merge pull request #43 from cisagov/improvement/apb-events
...
Allow events from apb to rebuild this repository weekly.
2020-05-01 10:11:49 -04:00
Felddy
8c99c5294a
Allow events from apb to rebuild this repository weekly.
2020-04-30 23:31:59 -04:00
Hillary
175ae71602
Merge pull request #42 from cisagov/hillaryj-owner
...
Update CODEOWNERS
2020-04-15 09:46:54 -04:00
Hillary
c8b4bcf126
Update CODEOWNERS
2020-04-14 12:43:18 -04:00
Nick M
89b098aefc
Merge pull request #41 from cisagov/bugfix/update_pre-commit_for_pre-commit-terraform_hook
...
Update pre-commit Hooks to Include Bugfix
2020-04-07 13:38:21 -04:00
Nicholas McDonnell
647b351997
Sort .gitignore entries.
2020-04-06 19:04:21 -04:00
Nicholas McDonnell
1f3d440a1a
Rename action to accurately reflect that we are only linting, not building.
...
Adjust description for pre-commit hook setup to better convey what is being
done.
2020-04-06 19:02:31 -04:00
Nicholas McDonnell
b01a0ee7bd
Explicitly install pre-commit hooks as its own step so it's clearer when the
...
failure is with setup rather than hooks running.
2020-04-06 13:47:18 -04:00
Nicholas McDonnell
0bc1aab45e
Ran pre-commit autoupdate to get the latest version of the
...
`pre-commit-terraform` hook since the PR I submitted,
https://github.com/antonbabenko/pre-commit-terraform/pull/100 ,
was approved. This will fix issues with `skeleton-tf-module` related to multiple
directories with Terraform code.
2020-04-06 12:05:57 -04:00
Nick M
757a861864
Merge pull request #40 from cisagov/improvements/update_pre-commit
...
Update pre-commit Hooks and Fix Broken Hook ID
2020-03-31 15:28:37 -04:00
Nicholas McDonnell
61790a9bbd
Fixed broken hook id for pre-commit-terraform:
...
terraform_validate_no_variables was changed to terraform_validate in the
following commit:
35e0356188
2020-03-31 14:41:10 -04:00
Nick M
f5fd431b45
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
...
Add markdownlint Configuration Option for MD024
2020-03-04 12:56:28 -05:00
