Nick M
89b098aefc
Merge pull request #41 from cisagov/bugfix/update_pre-commit_for_pre-commit-terraform_hook
...
Update pre-commit Hooks to Include Bugfix
2020-04-07 13:38:21 -04:00
Nicholas McDonnell
647b351997
Sort .gitignore entries.
2020-04-06 19:04:21 -04:00
Nicholas McDonnell
1f3d440a1a
Rename action to accurately reflect that we are only linting, not building.
...
Adjust description for pre-commit hook setup to better convey what is being
done.
2020-04-06 19:02:31 -04:00
Nicholas McDonnell
b01a0ee7bd
Explicitly install pre-commit hooks as its own step so it's clearer when the
...
failure is with setup rather than hooks running.
2020-04-06 13:47:18 -04:00
Nicholas McDonnell
0bc1aab45e
Ran pre-commit autoupdate to get the latest version of the
...
`pre-commit-terraform` hook since the PR I submitted,
https://github.com/antonbabenko/pre-commit-terraform/pull/100 ,
was approved. This will fix issues with `skeleton-tf-module` related to multiple
directories with Terraform code.
2020-04-06 12:05:57 -04:00
Nick M
757a861864
Merge pull request #40 from cisagov/improvements/update_pre-commit
...
Update pre-commit Hooks and Fix Broken Hook ID
2020-03-31 15:28:37 -04:00
Nicholas McDonnell
61790a9bbd
Fixed broken hook id for pre-commit-terraform:
...
terraform_validate_no_variables was changed to terraform_validate in the
following commit:
35e0356188
2020-03-31 14:41:10 -04:00
Nick M
f5fd431b45
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
...
Add markdownlint Configuration Option for MD024
2020-03-04 12:56:28 -05:00
Nicholas McDonnell
d791334352
Add a rule for markdownlint to allow multiple headers with the same name as long
...
as they are not nested in the same heading group.
2020-03-04 10:56:39 -05:00
Nick M
241484abe4
Merge pull request #38 from cisagov/change_cache_paths_to_env_variables
...
Change Cache Paths to Environment Variables
2020-03-04 10:46:53 -05:00
Nicholas McDonnell
478f1688a1
Change the cache paths from hardcoded values in their appropriate blocks to environment variables declared before the job block.
2020-03-04 08:41:59 -05:00
Nick M
b58f7a1546
Merge pull request #37 from cisagov/add_python_version_to_cache_keys
...
Incorporate the Python version into keys for pip and pre-commit caches.
2020-03-03 18:02:33 -05:00
Nicholas McDonnell
454864bc02
Incorporate the Python version into keys for pip and pre-commit caches.
...
This should resolve the issue seen when the Python version changes before there
is an update to .pre-commit-config.yml which results in pre-commit pointing to
a non-existent Python installation.
2020-03-03 16:49:53 -05:00
Shane Frasier
c7f339fb84
Merge pull request #36 from cisagov/improvement/add-mypy-cache-to-gitignore
...
Add .mypy_cache to .gitignore
2020-03-02 10:21:27 -05:00
Jeremy Frasier
bf366086f4
Add .mypy_cache to .gitignore
2020-03-02 08:11:32 -05:00
Mark Feldhousen
6369cc6594
Merge pull request #35 from cisagov/improvement/static_type_checking
...
Autoupdate pre-commit hooks. Add mypy.
2020-02-21 00:02:49 -05:00
Felddy
067ee0850c
Autoupdate pre-commit hooks. Add mypy.
2020-02-20 22:14:08 -05:00
Nick M
a17986bdae
Merge pull request #34 from cisagov/improvements/use_verbose_pip_switches
...
Use Verbose pip Switches
2020-02-19 10:15:25 -05:00
Nicholas McDonnell
e96577bce4
All references to '-r' for pip calls have been replaced with the more verbose '--requirement'.
2020-02-18 18:04:06 -05:00
Nick M
16872bfc74
Merge pull request #33 from cisagov/improvement/update_pre-commit_hooks
...
Update pre-commit hooks (and flip Actions cache order in workflow).
2020-02-12 11:31:52 -05:00
Nicholas McDonnell
d99fd00bc2
Flip cache order to mirror how it is done downstream.
2020-02-12 00:14:11 -05:00
Nicholas McDonnell
b857939b3d
Run pre-commit autoupdate.
2020-02-12 00:01:16 -05:00
Nick M
8116a89b8c
Merge pull request #32 from cisagov/improvements/update_python_version_and_checkout_action
...
Update Python and actions/checkout Versions
2020-02-11 11:30:55 -05:00
Nicholas McDonnell
f7a4166ad6
Update Python version used to 3.8
...
Update actions/checkout to v2
Update formatting to match downstream children
2020-02-11 10:41:17 -05:00
Nick M
3f6d654ad6
Merge pull request #31 from cisagov/improvements/add_wsl_instructions
...
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
2020-02-10 11:58:59 -05:00
Nicholas McDonnell
532751627a
Backported changes to CONTRIBUTING.md from the development guide.
2020-02-10 10:39:07 -05:00
Shane Frasier
a8e35d0fed
Merge pull request #29 from cisagov/improvement/better-handle-prs-from-forked-repos
...
Make workflow run when a PR is opened, synchronized, or reopened
2020-01-27 07:59:10 -05:00
Jeremy Frasier
dbd589d2e2
Improve list formatting
2020-01-24 17:10:49 -05:00
Jeremy Frasier
2fa4cbe194
Make workflow run when a PR is opened, synchronized, or reopened
...
A user forked cisagov/scan-target-data and created a pull request, but
the required GitHub Action(s) did not run. This is presumably because
the user does not have Actions enabled in his or her fork. Ideally,
the required Action(s) would run in cisagov/scan-target-data when a PR
to merge changes back is created. Based on my reading of this link,
adding the "pull_request" event type should make this happen:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
2020-01-24 16:45:48 -05:00
Nick M
09afdf3a7c
Merge pull request #28 from cisagov/improvements/pre-commit_add_isort
...
Add isort tool to pre-commit hooks.
2019-12-23 11:50:07 -05:00
Nicholas McDonnell
18b5d12c78
Add seed-isort-config and isort to pre-commit hooks.
...
Add isort configuration file.
2019-12-19 15:32:36 -05:00
Mark Feldhousen
b89eecb788
Update CODEOWNERS
2019-11-18 11:11:06 -05:00
Mark Feldhousen
3f9376036c
Merge pull request #25 from cisagov/improvement/codeowners
...
Add codeowners file with team OIS maintainers.
2019-11-18 10:43:39 -05:00
Felddy
e39dc88819
Add codeowners file with team OIS maintainers.
...
See:
https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
2019-11-18 10:33:28 -05:00
Mark Feldhousen
5e269301d3
Merge pull request #24 from cisagov/improvement/pre_commit_default_python
...
Set a default language for pre-commit hooks
2019-11-15 12:33:53 -05:00
Felddy
30a16a3842
Autoupdate pre-commit hooks.
2019-11-15 11:51:46 -05:00
Felddy
7c0b30b495
Force pre-commit hooks to use python3.
...
Fixes #23
2019-11-15 11:50:38 -05:00
Mark Feldhousen
10bbfdf3ae
Merge pull request #22 from cisagov/improvement/action_cache
...
Add GitHub action caching of pre-commit hooks and pip packages.
2019-11-05 15:54:02 -05:00
Felddy
99c611557e
Remove search for previous pre-commit caches.
...
These seem to be very large caches. Restoring an old one and updating
it results in a cache larger than the maximum allowed cache size: 200MB.
"Cache size of 254757924 bytes is over the 200MB limit, not saving
cache."
So if the config changes it is best to just take the cache-miss and
start from scratch.
2019-11-05 14:51:49 -05:00
Mark Feldhousen
c26ea017cf
Merge branch 'develop' into improvement/action_cache
2019-11-05 14:36:08 -05:00
Felddy
5d5567d303
Add GitHub action caching of pre-commit hooks and pip packages.
2019-11-05 14:27:20 -05:00
Nick M
7dfd8bf735
Merge pull request #21 from cisagov/pre-commit_autoupdate_2019-11-02
...
Re-enable ansible-lint and autoupgrade.
2019-11-05 11:47:19 -05:00
Nicholas McDonnell
3c78dd98a6
Re-enabled ansible-lint and ran pre-commit autoupgrade.
2019-11-02 19:48:42 -04:00
Mark Feldhousen
12b91c4850
Merge pull request #20 from cisagov/improvement/actions
...
Replace Travis-CI with GitHub actions
2019-10-18 11:18:27 -04:00
Felddy
b11e39abd7
Remove extra line.
2019-10-18 11:00:39 -04:00
Felddy
b31ad8591f
Disable ansible-lint until they fix their setup.py
...
See: https://github.com/ansible/ansible-lint/issues/590
2019-10-18 10:46:32 -04:00
Felddy
02fb008d62
Fix action shield link
2019-10-18 10:40:58 -04:00
Felddy
05a136bb11
Replace Travis-CI with GitHub actions.
2019-10-18 10:39:22 -04:00
dav3r
b189690a28
Merge pull request #18 from cisagov/improvement/updates_from_precommit_autoupdate
...
Add updates from running pre-commit autoupdate
2019-10-18 10:21:43 -04:00
Dave Redmin
78a230d46c
Add updates from running pre-commit autoupdate
2019-10-18 10:10:19 -04:00
