a3c5aa71cf
Add an ansible-lint configuration file
...
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass
pre-commit. See here for for a list of the elements that can exist in this
file: https://ansible-lint.readthedocs.io/en/latest/configuring.html
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
b78b832269
Update the ansible-lint version for pre-commit
3 years ago
f3000e5ff4
Merge pull request #91 from cisagov/improvement/pre-commit_update
...
Update `pre-commit` Hooks
3 years ago
b66988de8c
Update pre-commit hooks
...
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with switching to v5.
3 years ago
1b5cd2546b
Merge pull request #90 from cisagov/improvement/enable_terraform_validate
...
Enable terraform validate pre-commit hook
3 years ago
b51dbb577e
Revert "Temporarily use cisagov/setup-env-github-action@improvement/support_tf_0.13"
...
This reverts commit 6a7fbf07bd
3 years ago
895a692ad8
Remove lint job step to initialize Terraform directories
...
Initialization will now be done during the "terraform validate" step.
3 years ago
6a7fbf07bd
Temporarily use cisagov/setup-env-github-action@improvement/support_tf_0.13
...
This change will be reverted when testing is completed.
3 years ago
60b612ded5
Enable terraform validate pre-commit hook
...
This hook should now work as expected in most, if not all of our repos
now that we are finally updating to terraform 0.13.x (on our way to
1.0.x).
3 years ago
a4196eeb94
Merge pull request #88 from cisagov/improvement/use_setup-terraform_in_gha_workflow
...
Use the hashicorp/setup-terraform Action to Install Terraform in GHA Workflow
3 years ago
c9c6562df0
Merge branch 'develop' into improvement/use_setup-terraform_in_gha_workflow
3 years ago
bd030a1c04
Merge pull request #89 from cisagov/improvement/specify_mdl_rules
...
Add markdownlint Rules to Enforce Specific Formatting
3 years ago
f63276642c
Merge branch 'develop' into improvement/specify_mdl_rules
3 years ago
929bab582f
Merge pull request #85 from cisagov/dav3r-patch-1
...
Fix a typo
3 years ago
5459c2c394
Merge branch 'develop' into dav3r-patch-1
3 years ago
23f9cfd015
Update pre-commit hooks
...
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with switching to v5.
3 years ago
9848ff6944
Add a markdownlint rule for code blocks
...
This sets a specific rule for MD046 (code block style) instead of the default
value of "consistent".
3 years ago
7f324b9807
Add a markdownlint rule for horizontal rules
...
This sets a specific rule for MD035 (Horizontal rule style) instead of the
default value of "consistent".
3 years ago
f7140d8116
Use the hashicorp/setup-terraform Action
...
Instead of manually installing a Terraform binary we can leverage the Action
provided by Hashicorp to do the same thing.
3 years ago
a0f24937d6
Fix a typo
3 years ago
81cdb4da94
Merge pull request #84 from cisagov/improvement/replace_beautysh_with_shfmt
...
Replace beautysh hook with cisagov/pre-commit-shfmt
3 years ago
3e83a800f0
Merge branch 'develop' into improvement/replace_beautysh_with_shfmt
3 years ago
0e4fc41e4f
Merge pull request #82 from cisagov/improvement/install-tf-and-packer-for-linting
...
Install terraform and packer for the linting job
3 years ago
3e3b918cbe
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
3 years ago
382c39c4e9
Merge pull request #79 from cisagov/improvement/update_mdl_configuration
...
Update markdownlint Configuration
3 years ago
f6ad0e95d3
Merge branch 'develop' into improvement/install-tf-and-packer-for-linting
3 years ago
e607360128
Merge branch 'develop' into improvement/update_mdl_configuration
3 years ago
41a52860b8
Merge pull request #80 from cisagov/improvement/add_pre-commit_hook
...
Add the validate_manifest Hook to pre-commit Configuration
3 years ago
c17800a7fd
Merge branch 'develop' into improvement/add_pre-commit_hook
3 years ago
d7dcfee3b5
Merge pull request #83 from cisagov/maintenance/update_pre-commit_hooks
...
Update pre-commit Hooks
3 years ago
1708b5c45a
Update pre-commit hooks
...
This is performed by running `pre-commit autoupdate`, but with the
`ansible-lint` hook held back manually.
3 years ago
2b48e75b23
Apply changes from the shfmt pre-commit hook
3 years ago
406b6880bd
Replace the beautysh hook with pre-commit-shfmt
...
We have had a difficult time with how beautysh parses some shellscripts. I went
in pursuit of an alternative and I believe shfmt to be a good alternative.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
e2a729d0b1
Install the shfmt tool for GHA
...
The `shfmt` tool does not ship on the GitHub Actions runners so we must install
it manually.
3 years ago
8ee2116f42
Prefer the newer "go install" syntax
...
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command ) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
337d1efb8f
Capitalize Go for consistency
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
bb6e566e3a
Move go installation so that it takes place before the cache task
...
Some variables defined in the go installation are used in the cache
task, so the go installation must happen first.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
181d1b2faf
Install a specific version of terraform-docs
...
Note that this change is dependent on the merging of
cisagov/setup-env-github-action#31 .
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
b629f7f623
Modify the Packer installation to model that of Terraform
...
The Terraform installation does not destroy the existing system
Terraform installation, and neither should the Packer installation.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
70414cff28
Remove unnecessary line in tasks
...
There is no reason to create /usr/bin/terraform. This is a vestige of
an earlier age.
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
c481043981
Break out the curl cache creation into its own step
...
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
3 years ago
106af21c04
Install terraform and packer for the linting job
...
We should be doing this because the Packer and Terraform pre-commit
hooks leverage the corresponding executables; therefore, it makes
sense to go ahead and install the particular versions of those
executables that we support. Also add support for optionally
debugging via tmate.
See also cisagov/skeleton-generic#74 .
3 years ago
d4781ee177
Add the validate_manifest hook from pre-commit
...
This hook will validate any pre-commit hook manifest files in the repository.
3 years ago
f2a423095e
Add comments to markdownlint configuration
...
Now that this is a YAML file we can add comments explaining the rule
modifications we use. This will make it easier to edit or expand in the future.
3 years ago
ce173f401d
Switch to a YAML markdownlint configuration file
...
This converts the existing `.mdl_config.json` file to an equivalent
`.mdl_config.yaml` file. The reference in the markdownlint pre-commit hook
configuration is updated to match.
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
3 years ago
afc6bd6f6d
Add rule for image headers
...
Add <h1> and <img> tags to the allowed list for MD033 (HTML elements) to
support using an image as the first thing in a markdown file (header image).
3 years ago
1e8f822391
Add style enforcement rules
...
Add rules to enforce ATX-closed headers, dashes for unordered list elements,
and `1.` for ordered list elements.
3 years ago
b0e7f014e3
Merge pull request #70 from cisagov/improvement/gitignore_me
...
Improve gitignore file comments and organization.
3 years ago
e140c33929
Merge branch 'develop' into improvement/gitignore_me
3 years ago
02aefa1644
Merge pull request #75 from cisagov/documentation/update_pyenv_instructions
...
Update Instructions for Configuring pyenv
3 years ago
Nicholas McDonnell
dav3r
Shane Frasier